search

aleksandr-m / gitflow-maven-plugin

The Git-Flow Maven Plugin supports various Git workflows, including GitFlow and GitHub Flow. This plugin runs Git and Maven commands from the command line.
https://aleksandr-m.github.io/gitflow-maven-plugin/
Apache License 2.0
494 stars 182 forks source link

version-update "skipTag" not working when set in the config section of the pom.xml #360

Closed dagutten closed 2 years ago

dagutten commented 2 years ago

When testing the version-update goal I noticed that the "skipTag" config is not working when set inside the element. This property is only working when provided as a maven property "-DskipTag=true".

`

true << -- This one works in version-update goal true <<-- This one is ignored ` Console output: mvn gitflow:version-update `[INFO] Comparing local branch 'release/1.0.0' with remote 'origin/release/1.0.0'. What is the update version? [1.0.0-RC6]: [INFO] Version is blank. Using default version. [INFO] Updating version(s) to '1.0.0-RC6'. [INFO] Committing changes. [INFO] Creating '1.0.0-RC6' tag. ` If I execute the same goal but including "-DskipTag=true". Console output: mvn gitflow:version-update -DskipTag=true `[INFO] Version is blank. Using default version. [INFO] Updating version(s) to '1.0.0-RC7'. [INFO] Committing changes. [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS `
dagutten commented 2 years ago

nevermind, was an issue with my config section