search

aleksandr-m / gitflow-maven-plugin

The Git-Flow Maven Plugin supports various Git workflows, including GitFlow and GitHub Flow. This plugin runs Git and Maven commands from the command line.
https://aleksandr-m.github.io/gitflow-maven-plugin/
Apache License 2.0
487 stars 180 forks source link

Move to java 8 and update dependencies #369

Closed aleksandr-m closed 10 months ago

DRoppelt commented 1 year ago

if java8 becomes the baseline, the plugin versions pinned with this can be pulled up to more recent versions: https://github.com/aleksandr-m/gitflow-maven-plugin/issues/330

for instance, versions-maven-plugin with 2.8.1 from 2010 pulls in strutsv1 (which we in our org noticed as the mvn-repositury was flaggen on our build nodes)

image

DRoppelt commented 1 year ago

The latest maven release, 3.9.0, now also has Java 8 as baseline https://maven.apache.org/docs/3.9.0/release-notes.html

Minimum Java version to use with Maven 3.9.0 is raised to Java 8.

I wanted to check if the project & its testcases work with maven 3.9.0, but are not runnable due to that change. I will prepare a PR for java8 but I am not offended if it lays around for a while.

DRoppelt commented 1 year ago

I got stuck for a while since the tests kept being red, I missed that this has changed meanwhile https://github.com/aleksandr-m/gitflow-maven-plugin/commit/3327fb55f277882c0d89b9c6b7de440de1c08204 this was not related, nvm

PR is in progress

DRoppelt commented 1 year ago

Now that 1.20.0 is released... what do you think about bringing this ticket/PR into the next release? And if so, when?

I think that you mentioned that this ticket was more for intent than actually working on it in november. With the change of maven 3.9.X having java 8 as minimum version (https://maven.apache.org/docs/3.9.0/release-notes.html), it feels like this is something that can be introduced in your plugin too?

aleksandr-m commented 10 months ago

Done.