search

aleksandr-m / gitflow-maven-plugin

The Git-Flow Maven Plugin supports various Git workflows, including GitFlow and GitHub Flow. This plugin runs Git and Maven commands from the command line.
https://aleksandr-m.github.io/gitflow-maven-plugin/
Apache License 2.0
498 stars 181 forks source link

Pull request on feature branch because of needed review #393

Open baedorf opened 1 year ago

baedorf commented 1 year ago

Normally, I would implement a feature and a colleage should review the implementation before merging the feature into develop. After finishing the review, the plugin should be executed to merge feature into develop. Is this possible?

aleksandr-m commented 1 year ago

@baedorf What exactly? What do you want plugin to do?

baedorf commented 1 year ago

I don't know if its part of gitflow strategy, perhaps I need an additional goal like feature-review. This should create a pull request. Within this pull request, a code reviews can be performed. After review is finished (organizational task), feature-finish should merge pull request and update dependencies/versions like in actual implementation.

aleksandr-m commented 1 year ago

Pull request where? For example when using gitlab, merge requests can be created using git push options. See readme to configure this in plugin.

baedorf commented 1 year ago

I need the for github and can't find push options as linked in gitlab. Could you please provide an example on how to perform this with yout plugin?

aleksandr-m commented 1 year ago

AFAIK GitHub doesn't provide means of automatically creating PR-s from commits.