Return ellipsoid coefficients

aleksandrbazhin / ellipsoid_fit_python

Find ellipsoid fit for arbitrary data with python/numpy, plot it or write to file.

MIT License

75 stars 20 forks source link

Return ellipsoid coefficients #6

Closed Georacer closed 4 years ago

Georacer commented 4 years ago

Hello!

I have added the ellipsoid expression coefficients as a return argument from the get_ellipsoid_fit function.

I know this change is breaking the API, but I have found need for it and it is also closer to the original MATLAB version: https://www.mathworks.com/matlabcentral/fileexchange/24693-ellipsoid-fit

Have a nice day!

aleksandrbazhin commented 4 years ago

Hi! Thanks for input - I think API consistency is not a problem, since it is not a finished library, just some code shared, so the user will modify it for his needs. But also it is reasonable to have API closer to MATLAB, maybe even return chi2. I will merge, thank you again.