aleksey-hoffman / sigma-file-manager

"Sigma File Manager" is a free, open-source, quickly evolving, modern file manager (explorer / browser) app for Windows and Linux.
https://sigma-file-manager.vercel.app
Other
4.45k stars 164 forks source link

no audio in quickview player for mkv files #155

Open githubxnoob opened 3 years ago

githubxnoob commented 3 years ago

Is there an existing issue for this?

Problem description

error image

as you can see the audio button is not clickable. its only playing video and no audio

this only happens with .mkv files.

mp4 works

Steps to reproduce

select any .mkv files and hit space. it will open quickview player and play the video without audio.

Environment

App version: 1.4.0 App page: navigator Operating System: x64, win32, 10.0.19042

github-actions[bot] commented 3 years ago

Consider supporting the developer on Patreon to increase priority of all your issues, get access to private discord and other rewards.
Patreon page: https://www.patreon.com/sigma_file_manager

aleksey-hoffman commented 3 years ago

I just tried opening an mkv video. Audio is working. Try another video. Maybe this one has unsupported audio format

Also try opening it in a new tab of your Chrome and Edge browser (you can drag & drop the video there)

Ansh4011 commented 3 years ago

@aleksey-hoffman Hi, I checked this out and it happened with one of my videos too. I suspect the number of channels to be the cause though, have tried with 2 5.1 audio channel videos. The video which has audio in 5.1 channels wasn't showing any audio in SFM whereas the stereo audio was working perfectly fine.

aleksey-hoffman commented 3 years ago

@Ansh4011 thanks for testing. I have videos with different audio tracks

I could make it convert audio formats on the fly, but it would slow down preview loading and also create a duplicate file (or change the audio track in the original video)

Ansh4011 commented 3 years ago

I could make it convert audio formats on the fly, but it would slow down preview loading and also create a duplicate file (or change the audio track in the original video)

Indeed! Fast previews and ofcourse the consumption of less resources is important in today's time for any computer owner.

Btw, I guess there is some conflict between the audio codec(channels, to be particular) and the preview script probably.

aleksey-hoffman commented 3 years ago

@Ansh4011 the app's UI is handled by Chromium. I have no control over it. So, if it cannot decode the audio, all I can do is make the app convert the audio format of the video and only then display that modified video instead.

But this will:

And as you said, it would increase CPU and drive usage.

Ansh4011 commented 3 years ago

Oh, I get it. In that case I think it is better as it is right now. Thanks :)

aleksey-hoffman commented 3 years ago

Yeah, I'm not sure what else can be done. @githubxnoob if you test the video in Google Chrome and it's not working there either, consider opening a bug report on Chromium website: https://bugs.chromium.org/p/chromium/issues/list

RainyGrass commented 1 week ago

Hello, the problem I am facing is exactly the opposite of yours. When my computer plays MKV files, the screen is blank and I can only hear the audio. My computer is Windows 11. How can I solve this problem? image