search

aleksey-makarov / melf

A Haskell library to parse/serialize Executable and Linkable Format (ELF)
BSD 3-Clause "New" or "Revised" License
5 stars 1 forks source link

Test data is missing from hackage tarball #1

Closed sternenseemann closed 2 years ago

sternenseemann commented 2 years ago

It's not possible to run the tests from the hackage tarball, as the testdata is not included in extra-source-files.

aleksey-makarov commented 2 years ago

Is it required to be able to run the tests from the hackage tarball? The test data is huge, I did not want to make the hackage tarball big.

sternenseemann commented 2 years ago

It is not technically a requirement. Stackage (which is opt-in and requires it) and us (that is nixpkgs) use them to verify that a package is working correctly before shipping it to downstream users. Using the hackage tarballs for this makes this less complicated.

You are free to not distribute the test data via hackage, we can just disable the tests (which is the current situation) or disable the test suites that require the data as well.

aleksey-makarov commented 2 years ago

As a trade off I think I will include two test files in the next version so that a reduced set of tests passes without any source intervention, but the tarball keeps small. I would appreciate your judgement on this. Thank you.

sternenseemann commented 2 years ago

Sounds like a good idea! If tests are a big concern, building from the github repo is always an option.