search

aleksey-saenko / MusicRecognizer

An Android application for music recognition that uses AudD and ACRCloud services to perform song identification.
GNU General Public License v3.0
431 stars 10 forks source link

Add French language #41

Closed ysard closed 9 months ago

ysard commented 9 months ago

Hi, thanks for your nice project, you will find a french translation is this PR.

Note: I think there is an issue in the string "track_not_found" : "The track not found". a "was" is missing or the text should be just "Track not found" ?

aleksey-saenko commented 9 months ago

Nice work! Thanks for your contribution! I just added escaping for special characters, docs. Localization will be available in the next release. And thanks for pointing out the issue with this line in the English translation, I'll correct it locally. In the future, if you have any corrections, feel free to open a new pull request.

ysard commented 9 months ago

Thanks for the merge. Sorry for the missing escapement characters, I wasn't aware of this constraint on xml at all :o