aleksey-saenko / MusicRecognizer

An Android application for music recognition that uses AudD and ACRCloud services to perform song identification.
GNU General Public License v3.0
513 stars 14 forks source link

Better gestures for artwork viewer screen #77

Open BabyOilJohnson opened 1 month ago

BabyOilJohnson commented 1 month ago

Can you add the ability to exit from the full screen album cover by swiping from any directions(currently back gesture works). Thank you.

aleksey-saenko commented 1 month ago

Swiping in full-screen mode helps you move around a zoomed-in image. To navigate back (exit from image viewer), you use the typical Android back gesture from the edge. Why should a swipe up or down take you out of the screen? Or do you mean resetting the zoom to 1.0 with a back gesture instead of leaving the image viewer screen entirely?

BabyOilJohnson commented 1 month ago

Why should a swipe up or down take you out of the screen?

It will be more convenient than using back gesture.

For reference:

Screenrecord

https://github.com/user-attachments/assets/a46ed002-c6d0-454d-93d1-a7199565eb35

Or do you mean resetting the zoom to 1.0 with a back gesture instead of leaving the image viewer screen entirely?

No.

aleksey-saenko commented 1 month ago

Ok, I got it. This can be implemented for the mode when the picture is not zoomed. Thanks for the suggestion.