search

alekseykulikov / backbone-offline

[Deprecated] Allows your Backbone.js app to work offline
MIT License
720 stars 56 forks source link

Ajax options get lost on its way through the script. #18

Closed maxbeier closed 12 years ago

maxbeier commented 12 years ago

If you pass options to fetch() they get lost on its way to the final request.

For example if you have:

model.fetch({
   data: { action: model.methods.getAll }
});

you end up with a request without the parameter.

alekseykulikov commented 12 years ago

Thanks @maxbeier! Can you change backbone_offline.coffee and add spec?

maxbeier commented 12 years ago

Updated the coffee script version but don't know how to write an appropriate test.

alekseykulikov commented 12 years ago

Ok, cool, I will add spec a bit later and then merge it to master, thanks.

vadzimrudkouski commented 12 years ago

@Ask11 I also have found this issue and it would be nice to have a fix as soon as possible. Could you please merge it to master?