search

alelapi / material-ui-player

React/Material-UI Audio and Video Components
https://alelapi.github.io/material-ui-player/
MIT License
13 stars 2 forks source link

Basic usage gives TypeError #229

Closed DoubleDebug closed 2 years ago

DoubleDebug commented 2 years ago

Tried using the package today and the basic usage of the VideoCard component gave me a TypeError.

err1 err2

alelapi commented 2 years ago

Thanks for reporting it @DoubleDebug, I feel that it's probably related to React 18 but I need to do some digging on it

alelapi commented 2 years ago

Not a bug. I didn't notice that you didn't provide a ThemeProvider, maybe I should write it in the README but I took it for granted if you use MaterialUI. Also, you are using different versions of @mui/styles and @mui/material Here your sandbox corrected

DoubleDebug commented 2 years ago

Makes sense. Thanks for the reply! Would be nice if there was a note in the README about it.