search

alelapi / material-ui-player

React/Material-UI Audio and Video Components
https://alelapi.github.io/material-ui-player/
MIT License
13 stars 2 forks source link

Controls overlapping time #251

Closed omgMath closed 2 years ago

omgMath commented 2 years ago

Hi!

I've noted that for certain window widths the controls are overlapping the time. This also happens in the linked storybook: image

In my case it is a little more grave, since my font is presumably a bit larger... Plus the volume icon is missing?

image

Thanks for your work and open sourcing this library!

alelapi commented 2 years ago

Hi @omgMath, thanks for reporting it. Could you help me in reproducing it? Which browser are you using? which widths cause the overlapping?

EDIT: Ok, I got some clues.

I think you are playing with resolutions in the storybook, maybe switching between desktop and mobile or narrowing and enlarging, right? At some point storybook sets the value of forward and backward to undefined so the buttons disappear. It seems a storybook bug, if you set it again to true they'll reappear.

The overlapping seems caused by larger fonts only, please correct me if I'm wrong. Actually, this doesn't seem such a serious bug but anyway I'll try to fix

alelapi commented 2 years ago

I've just released a new version that should fix some problems

omgMath commented 2 years ago

Wow, great, thanks a lot. I'll try to have a look in the next couple of days, but sadly have a lot going on, so I'm not sure if I'm gonna make it before I'm away for 10 days...