search

alelievr / libft-unit-test

456 stars 88 forks source link

Fixed Makefile so at line 162 #118

Closed VincentGerard closed 2 years ago

VincentGerard commented 2 years ago

First of all thanks for this awesome test for libft, I managed to install it correctly on the school's Macs but found and issue at home on WSL. I work on Windows 10 with WSL and found this small error in the makefile that would not compile the .so file.

Error:

Line 162 in Makefile: @make -C $(LIBFTDIR) so

Error: make[1]: No rule to make target 'so'. Stop.     make: [Makefile:162: libft.so] Error 2

Fix:

Line 162 in Makefile: @gcc -shared -o $(LIBFTDIR)/$(SONAME) -fPIC $(LIBFTDIR)/*.c

alelievr commented 2 years ago

This will not work if gcc is not installed or libft sources are not in the LIBFTDIR folder.

See https://github.com/alelievr/libft-unit-test#linux