False positive in ft_toupper.c test

[pedrodesu]

#define THRESHOLD 'a' - 'A'

int ft_toupper(int c)
{
    if (c >= 'a' && c <= 'z')
    {
        return (c - THRESHOLD);
    }
    else
    {
        return (c);
    }
}

int ft_toupper(int c)
{
    if (c >= 'a' && c <= 'z')
    {
        return (c - ('a' - 'A'));
    }
    else
    {
        return (c);
    }
}

The first snippet fails, whereas the second one passes. They're equivalent and there doesn't seem to exist any apparent reason for the first one not to pass. I'm guessing it's some type of problem with macros?

[github-actions[bot]]

Hello! Thanks for contributing to the libft unit test.

Note that this repository is not maintained by the owner anymore, instead there is a bot that will automatically merge any reviewed pull requests. If you feel like it, here are some links that can help you submiting a change in the code base::

• Create a pull request from a fork
• List of people that can review your pull request
• Automatically closing an issue with a pull request

[pedrodesu]

Complete noob mistake on my part, there's no false positive. thx for the heads up @Kuninoto. closing.