search

alelievr / libft-unit-test

457 stars 88 forks source link

Fixing library compilation multiple threads error. #35

Closed JeanBonok closed 6 years ago

JeanBonok commented 6 years ago

Hi! I had an issue with the 42filechecker (which uses your program), because of multiple threads during the compilation the ar command started too early and failed. When I used your program alone the compilation worked randomly but never inside the 42filechecker process. Because the compilation process isn't too long I thought the -j option might be skipped. Thanks for your program, it's awesome! All the best.

alelievr commented 6 years ago

Hi, thanks for your pull request, this bug is caused because you missed something in the implementation of the re rule in your makefile (more info here: #30) but i think i'll accept you pr because this is not something to be test by this project and even the 42's implementation of re rule does not support the -j flag.

JeanBonok commented 6 years ago

Thanks a lot for your answer and the tip! That's right that they don't teach us the re rule that way but on the other hand, I would not have understood that subtlety without my "collide" with your program...