alelievr / libft-unit-test

455 stars 88 forks source link

Renamed functions and fixed prototype #62

Closed cacharle closed 4 years ago

alelievr commented 4 years ago

Hello, I don't understand this PR :)

The libft subject haven't changed right ? I see that in the subject it's still

char * ft_strsub(char const *s, unsigned int start, size_t len);
char * ft_strtrim(char const *s);

Did i missed something ?

cacharle commented 4 years ago

The subject I received changed

They also added bonus functions and how those functions are evaluated. We have to add a _bonus at the end of the file name containing the bonus function, we also have to add a bonus rule to our Makefile which compile the bonus.

Here is the pdf I got: https://github.com/HappyTramp/libft/blob/master/subject.en.pdf

alelievr commented 4 years ago

Ha yes ok, it makes sense :)

I guess that i'll merge that into master and create a new branch for the "old" libft subject so people can still use it