alelievr / libft-unit-test

455 stars 88 forks source link

Subject has change : lstmap now taking 3 param. #69

Closed ggjulio closed 4 years ago

ggjulio commented 4 years ago

lstmap proto updated

ggjulio commented 4 years ago

Subject has change.

Old proto :

t_list *ft_lstmap(t_list *lst, void *(*f)(void *));

New proto :

t_list *ft_lstmap(t_list *lst, void *(*f)(void *), void (*del)(void *));

Unless this 2 problems,everything else is fine.

alelievr commented 4 years ago

I did not find a way to make it crash using the old proto.

There was already some missing tests on the lst functions so that's not much of a problem :) But it's true that we could add tests for malloc protections (using the MALLOC_NULL macro)

By the way. I can't find a way to make lstdelone work.

Do you mean that the test functions doesn't work anymore ?