alelievr / libft-unit-test

455 stars 88 forks source link

Update test_functions.c #79

Closed xnio94 closed 4 years ago

xnio94 commented 4 years ago

in testing of memcmp : portable code should only depend on the sign of the returned value

alelievr commented 4 years ago

Hello, the REG macro in the tests functions you changed does exactly this, did you experience any issues while testing your memcmp on mac/linux ?

xnio94 commented 4 years ago

yes I experienced some issues while testing memcmp and after i reviewed the test code i didn't notice the REG macro so i made that conclusion I'm not sure what went wrong maybe it was something else sorry for bothering you