alemangui / pizzicato

Library to simplify the way you create and manipulate sounds with the Web Audio API.
https://alemangui.github.io/pizzicato/
MIT License
1.66k stars 130 forks source link

Fix identification of OscillatorNode objects in Safari v14+. Fixes #146. #147

Open jlyman opened 3 years ago

jlyman commented 3 years ago

This adds a secondary identifier for checking that an object is an OscillatorNode, to be compatible with how WebKit (Safari) changed their object identifiers.

I ran the tests and they were all still green on Firefox. I additionally ran the tests on Safari (but did not change the karma.config.js file to include Safari because I assume that many others will not have Safari available for test). The suite on Safari failed 11 tests, but I was able to correct two of them which were directly linked to this issue. I didn't look into the other failures. Everything should still be green on FF however.

Fixes #146.