alemart / opensurge

A retro game engine with a fun platformer for making your dreams come true!
http://opensurge2d.org
GNU General Public License v3.0
386 stars 33 forks source link

Characters who can't naturally roll can keep roll state while Down is held #87

Closed Soufon7 closed 1 year ago

Soufon7 commented 1 year ago

If a character's .chr file has the roll ability blocked, but the character is put into roll state by scripts, etc, they can roll from landing from midair like characters that do have the roll ability.

alemart commented 1 year ago

Good point. If a character has no roll ability, then player.roll() should be blocked.

Soufon7 commented 1 year ago

I'm not really for blocking them from rolling at all, just them being able to roll "again" after being forced to roll seems off to me. Blocking it 100% would make zoom tubes and the like incompatible with those characters.

alemart commented 1 year ago

Currently, only the manual activation of the rolling is blocked. We can keep this method too.

Please confirm: do you refer to the situation that is in this video?

https://github.com/alemart/opensurge/assets/221477/ffe8e1fa-5920-4877-bf95-db6f912370eb

Soufon7 commented 1 year ago

Yeah.

alemart commented 1 year ago

Okay, thank you.