search

alemart / speedy-vision

GPU-accelerated Computer Vision for JavaScript.
Apache License 2.0
175 stars 28 forks source link

Feature ImageData in SpeedyMediaSource #57

Closed kalwalt closed 7 months ago

kalwalt commented 7 months ago

Continue from PR #56

alemart commented 7 months ago

Nice! We can just change files src/core/speedy-media-source.js and src/utils/types.js. Let's leave the other files, including the typescript definitions, for a different commit. We haven't changed the image sink yet.

alemart commented 7 months ago

In addition, in SpeedyMedia.type, let's handle the case in which the image source is an ImageData. Let's make it return the string 'data':

https://github.com/alemart/speedy-vision/blob/48934ac8317a5b7c3a665af00c69d22e626b888a/src/core/speedy-media.js#L113-L138

alemart commented 7 months ago

Hi @kalwalt,

Please sign your commits - see CONTRIBUTING.md.

I ask you to remove all files from this PR, except:

kalwalt commented 7 months ago

Hi @kalwalt,

Please sign your commits - see CONTRIBUTING.md.

I ask you to remove all files from this PR, except:

  • src/core/speedy-media-source.js
  • src/core/speedy-media.js
  • src/utils/types.js

Maybe at this point it's better to recreate it. I'm using a GPG key to sign my commits but i will do as you mentioned in the contributing page. Sorry for this!

kalwalt commented 7 months ago

New updated PR #58

alemart commented 7 months ago

I think that it will be a better design to modify the existing image sink to introduce support for exporting an ImageData instead of creating a new node. I'll be doing that later.