search

alembics / disco-diffusion

Other
7.46k stars 1.13k forks source link

I hate that this program is a whole, would you pull out the function part? #109

Open prophetchen opened 2 years ago

prophetchen commented 2 years ago

And I done it. Could i commit it?

vsemecky commented 2 years ago

And I done it. Could i commit it?

I have a similar feeling about DD and would welcome cleaner and clearer code. If you have managed to separate the core functionality from the "colab related ballast", I would be really interested in your solution.

PS: If you want to commit it, first you have to fork the Disco Diffusion, then make changes and finally make a pull request.

aztecman commented 2 years ago

Howdy. So I am firmly in the opposing school of thought.

I find it much easier to develop based on seeing all of the fine details of the code in one place.

In the past, I worked with the google generative tools named 'lucid', and I found it extremely challenging to add on new features because of the compartmentalized structure.

I would argue, if clarity is desired, we should just have better documentation. I'm not against clean code, just against packing everything in boxes and stowing it out of sight.

I doubt that I can convince anyone here to abandon their view. I am merely sharing this in hopes that the core ipynb remains transparent.

PS my bud, entmike has been developing on a branch with a similar motivation (supposing I understand the issue correctly). https://github.com/entmike/disco-diffusion-1/blob/main/Simplified_Disco_Diffusion.ipynb