search

alembics / disco-diffusion

Other
7.46k stars 1.13k forks source link

Integrated liminial_diffusion_v1 and liminal_diffusion_source models #133

Open 0xphk opened 2 years ago

0xphk commented 2 years ago

Hi,

I added the two liminal_diffusion models from BrainArtLabs. Their collab link was shared on reddit, so I tried to integrate them. (https://colab.research.google.com/drive/1pHBrk8FsSmvu_TZREhZpK4jwmRBLebS_)

Models are: liminal_diffusion_v1 and liminal_diffusion_source

I've tested both models, but only on my local instance running on a 2070 with already downloaded models. Links and checksums are included, so download should work, but I couldn't test this here.

I really like this project and would love to contribute to it. As this is my second PR ever, please bear with me if I've done something wrong.

best wishes

aletts commented 2 years ago

Thanks for the PR! It looks all good, and that it'll work. I'll see about picking the version number, etc.

0xphk commented 2 years ago

Do you have an advice for integrating additional models? I've tested and integrated the two new KaliYuga-Ai models "lithographic" and "medieval" to a local repository. Should I create a new branch in the fork based on main (without liminal) or based on my changes in this branch? Or do I have to merge this one with main first and create a new branch from this? I'm not very familiar with branches and PR's so sorry for the beginner questions.

0xphk commented 2 years ago

I fixed the model settings for use in colab, somehow it worked locally but not in colab, now both work