search

alemuller / tree-sitter-make

MIT License
44 stars 16 forks source link

Remove the TODO test #19

Open aryx opened 1 year ago

aryx commented 1 year ago

This prevents to use this repository in other repository with automated testing because the tests currently fail.

test plan: npm test

aryx commented 1 year ago

@alemuller we would like to use your tree-sitter-make in semgrep, so people can write Semgrep rules to find errors in Makefiles, but those failing tests are annoying for our release process. Would you mind merging this PR? This would help us a lot.

aryx commented 1 year ago

This would help https://github.com/returntocorp/semgrep/issues/8087

aryx commented 1 year ago

ping @alemuller

aryx commented 1 year ago

@alemuller if you don't maintain this repo anymore, I'll fork it, but I'd rather avoid a fork if we can agree on merging this PR.

aryx commented 1 year ago

Ok I'll fork your repo then @alemuller . A bit sad. I would have rather avoided it.