search

alemuller / tree-sitter-make

MIT License
44 stars 16 forks source link

String parsing mistake #9

Closed matkuki closed 2 years ago

matkuki commented 2 years ago

Hi @alemuller,

Excellent work on the rewrite 👍

There is still an issue with strings that contain $ variables. When a variable is inserted, everything after a variable is not a string anymore. For example: image and: image

Same goes for variable declaration. This is good: image and this cancels the string: image

matkuki commented 2 years ago

Scratch that, I think that is my mistake in the way I parse nodes. Sorry

alemuller commented 2 years ago

The variables are like macros in C, ideally, they should be highlighted based on the context they are used. This feature isn't implemented in tree-sitter.