search

alenaksu / mdPickers

Material Design date/time pickers for Angular Material
MIT License
293 stars 216 forks source link

Numbers on clock face and AM/PM options not appearing in dialog #194

Closed ericodes closed 7 years ago

ericodes commented 7 years ago

hey @dpoetzsch!

I'm using your fork, thanks for creating that.

I'm seeing something odd, where the clock doesn't fully appear. image

Took a quick look in Dev Tools, and looks like clock.steps isn't defined. image

Was wondering if anyone else have having this issue? Removed and installed it a couple times just to check.

Thank you for your help!

ericodes commented 7 years ago

Nevermind, resolved it!

Was because I had chosen an older (1.4) Angular version with Bower resolutions. clock.steps were getting defined in anthis.$onInit which is from Angular 1.6, so just had to change the resolution.

dpoetzsch commented 7 years ago

Happy to hear your issue has been resolved. For the future: If you have an issue with the fork it might be better to open the issue there. We'll probably lose track of the states otherwise

LoganDupont commented 7 years ago

@dpoetzsch Is it normal that we can't find the issue page on a fork?

ericodes commented 7 years ago

Definitely @dpoetzsch! Are you able to turn on the Issues page for your fork? I wasn't able to see the issues tab either. Thanks again for maintaining it!

screen shot 2017-05-26 at 4 06 58 pm screen shot 2017-05-26 at 4 06 49 pm

dpoetzsch commented 7 years ago

Thanks for pointing that out @LoganDupont @ericodes I needed to enable issues on the fork for some reason. Should be working now :)