aleph-im / aleph-client

Lightweight Python Client library for the Aleph.im network
MIT License
11 stars 12 forks source link

ci: remove macOS 11 support #223

Closed Psycojoker closed 3 weeks ago

Psycojoker commented 3 weeks ago

Let's try removing it to see if it fixes the CI.

I'm not sure we want to keep supporting this version.

Fixes: https://github.com/aleph-im/aleph-client/issues/219

hoh commented 3 weeks ago

image

Still present somewhere... :thinking:

github-actions[bot] commented 3 weeks ago

This Pull Request involves a minor change to the CI/CD workflow file, specifically removing the macos-11 operating system from the matrix of tested environments. This change reduces the number of environments that the code will be tested in, but the impact on the overall functionality is minimal. The change is unlikely to introduce bugs, as it does not affect the actual codebase.

The diff:

@@ -13,7 +13,7 @@ jobs:
-        os: [macos-11, macos-12, macos-13, macos-14, ubuntu-20.04, ubuntu-22.04, ubuntu-24.04]
+        os: [macos-12, macos-13, macos-14, ubuntu-20.04, ubuntu-22.04, ubuntu-24.04]

indicates that macos-11 has been removed from the list of operating systems in the os variable. This change should not require a deep understanding of the project's architecture and can be reviewed quickly.

Psycojoker commented 3 weeks ago

image

Still present somewhere... 🤔

Yes, it should be good now (and I've did a quick grep, I can't find any other occurrence of it)

Also all test passed now.