Computing item_hash does not support non-inline message storage - Githubissues

aleph-im / aleph-message

Aleph.im message specification

MIT License

0 stars 5 forks source link

Computing item_hash does not support non-inline message storage #17

Closed hoh closed 10 months ago

hoh commented 2 years ago

See https://github.com/aleph-im/aleph-client/blob/3b7383bc4b6ec479cfc42d111622b8a8a1b9a4ea/src/aleph_client/asynchronous.py#L436-L450

Related to https://github.com/aleph-im/aleph-client/pull/106

MHHukiewitz commented 10 months ago

Should be fixed, as we compute the item_hash directly from the json dump here:

https://github.com/aleph-im/aleph-sdk-python/blob/59e22b5ee52ce8400311d7fc287a8cfcc037930c/src/aleph/sdk/client/authenticated_http.py#L606

and here:

https://github.com/aleph-im/aleph-message/blob/e1c0f474c394e2f7ce380d97dfac71bec157f056/aleph_message/models/__init__.py#L375