search

aleph-im / aleph-sdk-python

Python SDK library for the Aleph.im network
MIT License
2 stars 4 forks source link

Fix: `create_instance` required a program `encoding` #100

Closed hoh closed 5 months ago

hoh commented 5 months ago

Problem: Instances don't use program encodings. This argument was left from refactoring.

Solution: Drop the argument.

github-actions[bot] commented 5 months ago

The PR modifies multiple files in the aleph-sdk-python repository. The changes are extensive and may have a high potential for introducing bugs or affecting existing functionality. It appears to involve significant refactoring, new features, workflows, and modifications of existing logic. This is likely due to the large number of changed lines (1006) in this PR.

The diff shows that changes are made across multiple files including abstract.py which seems to be a core file for the SDK client. The refactoring includes removing an unused parameter 'encoding' and adding new parameters like 'volumes', 'volume_persistence', and 'ssh_keys'.

These changes could potentially affect other parts of the codebase that depend on this SDK, as well as any applications or services using it. Therefore, a deep understanding of the project architecture is required to review these changes effectively. Only experienced developers should be allowed to merge these changes into the main branch. The label 'BLACK' indicates this level of complexity and urgency for reviewing and merging these PRs.

Please note that while this PR may seem complex, it also provides new features or improvements which can benefit other parts of the codebase. It is important to consider the potential impact on the system as a whole when making decisions about whether to merge these changes.

This response was generated by the Code Review Categorizer (CRC) and is designed for machine parsing, so it follows markdown formatting and bullet points for clarity.