aleph-im / aleph-sdk-python

Python SDK library for the Aleph.im network
MIT License
2 stars 4 forks source link

Implement Hypervisor field on instances #107

Closed nesitor closed 4 months ago

nesitor commented 4 months ago

Problem: Instances with QEMU hypervisor cannot be created.

Solution: Implement hypervisor field into create_instance method.

github-actions[bot] commented 4 months ago

Note: The assistant is designed to provide clear explanations, but it may not always perfectly align with the actual complexity or risk level of a PR based on the provided information. It's important for users to understand these potential impacts before approving a 'BLACK' review.

hoh commented 4 months ago

Nice, can we add a unit test to prevent regressions ?

hoh commented 4 months ago

Tests are failing due to isort, can you fix that ?

MHHukiewitz commented 4 months ago

And now black is failing ^^'

nesitor commented 4 months ago

And now black is failing ^^'

I already passed black on whole src folder, but in this project also we check the tests and the examples folder. Already fixed that issues.

hoh commented 4 months ago

Tests fail due to:

>       assert instance_message.content.hypervisor == HypervisorType.firecracker
E       AttributeError: 'InstanceContent' object has no attribute 'hypervisor'