Remove double declaration of ethereum dependencies

aleph-im / aleph-sdk-python

Python SDK library for the Aleph.im network

MIT License

2 stars 4 forks source link

Remove double declaration of ethereum dependencies #109

Closed MHHukiewitz closed 4 months ago

MHHukiewitz commented 4 months ago

Now only required if installed with pip install aleph-sdk-python[ethereum].

hoh commented 4 months ago

Are we certain that neither of these libraries is used for something outside ethereum ?

MHHukiewitz commented 4 months ago

Now I'm certain, ETHAccount was imported as a default value for _load_account() in aleph.sdk.account

MHHukiewitz commented 4 months ago

There still seems to be some place where the ethereum dependencies are being imported by default in aleph.sdk, I will have to investigate, but I think it might have to do something with eciespy and coincurve being still present in the default installation. (See #110 for eciespy)

github-actions[bot] commented 4 months ago

Failed to retrieve llama text: POST 404: File Not Found

MHHukiewitz commented 4 months ago

Closing this as important foundation messages are signed with ETH and might need to be validated in future.