search

aleph-im / aleph-sdk-python

Python SDK library for the Aleph.im network
MIT License
2 stars 4 forks source link

Add file_path param to `download_file()` to directly download files to disk #115

Closed MHHukiewitz closed 3 months ago

MHHukiewitz commented 3 months ago

Instead of keeping them in memory. Addresses #37.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 96.72131% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.17%. Comparing base (ea4acdc) to head (69b9cf0).

Files Patch % Lines
tests/unit/conftest.py 93.10% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #115 +/- ## ========================================== + Coverage 83.67% 84.17% +0.50% ========================================== Files 27 27 Lines 1084 1131 +47 Branches 181 188 +7 ========================================== + Hits 907 952 +45 - Misses 175 176 +1 - Partials 2 3 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MHHukiewitz commented 3 months ago

@hoh I think codecov is incorrectly configured. It currently also measures test file coverage... Which doesn't make sense.

hoh commented 3 months ago

@hoh I think codecov is incorrectly configured. It currently also measures test file coverage... Which doesn't make sense.

Why not ? Tests that don't run do not make sense.

MHHukiewitz commented 3 months ago

Why not ? Tests that don't run do not make sense.

Because I just added some cleanup checks after downloading to the file, in order to check the automatic directory and file creation every time correctly