search

aleph-im / aleph-sdk-python

Python SDK library for the Aleph.im network
MIT License
2 stars 4 forks source link

Fix Hashing for Caching Dependencies in Build Wheel GH Action #116

Closed MHHukiewitz closed 3 months ago

MHHukiewitz commented 3 months ago

Still tried to hash now-nonexistant setup.cfg and setup.py files to determine hash to lookup cached dependencies.

This causes the latest CI/CD flow on main to fail.

github-actions[bot] commented 3 months ago

The PR is modifying the GitHub Actions workflow file build-wheels.yml in the repository aleph-im/aleph-sdk-python. The changes involve updating the cache key for building wheels in Python. This change could potentially affect other parts of the codebase that rely on this specific caching mechanism, leading to potential bugs or issues if not handled correctly.

The new cache key is ${{ runner.os }}-build-wheels-${{ hashFiles('pyproject.toml') }} which means it will depend on the content of the pyproject.toml file for caching purposes. This could potentially lead to issues if the structure or contents of this file change, as it influences how dependencies are cached and built.

In conclusion, while 'BLACK' PRs can be challenging due to their potential impact on other parts of the codebase, they require careful consideration and review by experienced developers. The label should only be used when necessary.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.67%. Comparing base (2a0b789) to head (37284d4).

:exclamation: Current head 37284d4 differs from pull request most recent head ca2bfda. Consider uploading reports for the commit ca2bfda to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #116 +/- ## ======================================= Coverage 83.67% 83.67% ======================================= Files 27 27 Lines 1084 1084 Branches 181 181 ======================================= Hits 907 907 Misses 175 175 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MHHukiewitz commented 3 months ago

We should probably start upgrading to Pydantic 2 at some point