aleph-im / aleph-sdk-python

Python SDK library for the Aleph.im network
MIT License
2 stars 4 forks source link

Fix: No notification when dependency update breaks #119

Closed hoh closed 2 months ago

hoh commented 3 months ago

Problem: Since the SDK is a library, it should not enforce the version of the libraries it requires too strictly.

This causes issues when an incompatible dependency upgrade breaks compatibility without anyone noticing except for the next CI build.

Solution: Run tests daily with the latest dependencies.

github-actions[bot] commented 3 months ago

The workflow is scheduled to run every day at 04:00 UTC, which could potentially affect the reliability of the library if not properly managed. This is a moderate risk as it involves a scheduled task that runs at a specific time.

The PR includes changes to the .github/workflows directory, which is a configuration directory for GitHub Actions. GitHub Actions are used to automate, customize, and execute software development workflows.

Please note that this PR is categorized as RED as it includes changes that could potentially break the functionality of the library if not properly managed. This PR also includes a new scheduled workflow, which could potentially disrupt the existing functionality of the library.

Here's a summary of the changes:

diff --git a/.github/workflows/pytest.yml b/.github/workflows/pytest.yml
index 69382cc..89c3dab 100644
--- a/.github/workflows/pytest.yml
+++ b/.github/workflows/pytest.yml
@@ -7,6 +7,11 @@ on:
   pull_request:
     branches:
        - main
+  schedule:
+     # Run every night at 04:00 (GitHub Actions timezone) 
+     # in order to catch when unfrozen dependency updates
+     # break the use of the library.
+     - cron: '4 0 * * *'

 jobs:
   build:

Please review this PR carefully and consider the potential impact on the library's functionality.