aleph-im / aleph-sdk-python

Python SDK library for the Aleph.im network
MIT License
2 stars 4 forks source link

Feature: Allow User to control their VM #124

Closed 1yam closed 2 weeks ago

1yam commented 1 month ago

Summary This feature introduces new capabilities for users to manage their virtual machines (VMs) directly. The following functionalities are included:

github-actions[bot] commented 1 month ago

Explanation: The PR adds a new file vmclient.py to the project. This file includes a class VmClient that interacts with a virtual machine via HTTP requests. The class has methods to perform various operations on the virtual machine, such as starting, stopping, rebooting, erasing, expiring, and notifying about the allocation of a virtual machine. This level of complexity is suitable for a 'RED' review as it involves adding new functionality and modifying existing code, which may require a deep understanding of the project architecture.

Highlights:

Marksdown:

### Categorization: RED

#### New File: vmclient.py
The PR adds a new file `vmclient.py`. This file includes a class `VmClient` that interacts with a virtual machine via HTTP requests.

#### New Class: VmClient
The PR adds a new class `VmClient`. This class has methods to perform various operations on the virtual machine, such as starting, stopping, rebooting, erasing, expiring, and notifying about the allocation of a virtual machine.

#### Implementation of methods for interacting with a virtual machine
The PR implements various methods for interacting with a virtual machine, such as starting, stopping, rebooting, erasing, expiring, and notifying about the allocation of a virtual machine.

The response ends with the categorization ('RED'), followed by the highlights and markdown formatting.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@214db7c). Learn more about missing BASE report. Report is 3 commits behind head on main.

:exclamation: Current head c6c8cab differs from pull request most recent head 2b3b63f

Please upload reports for the commit 2b3b63f to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #124 +/- ## ======================================= Coverage ? 84.15% ======================================= Files ? 27 Lines ? 1130 Branches ? 188 ======================================= Hits ? 951 Misses ? 176 Partials ? 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

Failed to retrieve llama text: POST 504:

504 Gateway Time-out

The server didn't respond in time.

hoh commented 1 month ago

Can you add tests on the new code ?

Psycojoker commented 4 weeks ago

Isn't this whole PR missing any form of documentation '-'?

Psycojoker commented 2 weeks ago

there are still some possible amelioration on the test and doc but these can be done in a separate PR

Have you open a clickup ticket for that?

olethanh commented 2 weeks ago

@Psycojoker https://app.clickup.com/24395970/v/l/6-901502681758-1