search

aleph-im / aleph-sdk-python

Python SDK library for the Aleph.im network
MIT License
2 stars 4 forks source link

Add new Confidential fields #137

Closed nesitor closed 2 weeks ago

nesitor commented 3 weeks ago

Problem: As a user we cannot create a confidential VM using the SDK.

Solution: Implement new confidential VM fields.

github-actions[bot] commented 3 weeks ago

The PR also contains a mix of small changes and large changes. Small changes include changes to the 'Payment' class, which appears to be a simple refactoring. Large changes include the complex modifications to the 'HostRequirements', 'NodeRequirements', and 'TrustedExecutionEnvironment' classes.

Overall, the PR appears to be complex and may have a high potential for introducing bugs. Only the most experienced developers should review this PR.

--- aleph-im/aleph-sdk-python

Category: RED

Changes to HostRequirements class in 'aleph/sdk/client/authenticated_http.py' file. This change involves a complex addition and deletion of methods and properties, which may impact the behavior of the code in unexpected ways.

Changes to test_create_confidential_instance function in 'tests/unit/test_asynchronous.py' file. This change involves a complex modification, which may impact the behavior of the tests in unexpected ways.

This PR contains a mix of small changes and large changes, which may increase the risk of introducing bugs. Only the most experienced developers should review this PR.

Changes to HostRequirements class in 'aleph/sdk/client/authenticated_http.py' file. This change involves a complex addition and deletion of methods and properties, which may impact the behavior of the code in unexpected ways. 

Changes to test_create_confidential_instance function in 'tests/unit/test_asynchronous.py' file. This change involves a complex modification, which may impact the behavior of the tests in unexpected ways. 

This PR contains a mix of small changes and large changes, which may increase the risk of introducing bugs. Only the most experienced developers should review this PR.

--- aleph-im/aleph-sdk-python

This PR appears to be categorized as 'RED'. The diff contains changes to the 'aleph/sdk/client/authenticated_http.py' file, which appears to be a part of the SDK library for the Aleph.im network. This change involves altering the 'HostRequirements' class, which appears to be a complex modification. The PR also contains changes to the 'test_asynchronous.py' file, which appears to be a part of the unit tests for the SDK. These changes involve altering the 'test_create_confidential_instance' function, which appears to be a complex modification.

The PR also contains a mix of small changes and large changes. Small changes include changes to the 'Payment' class, which appears to be a simple refactoring. Large changes include the complex modifications to the 'HostRequirements', 'NodeRequirements', and 'TrustedExecutionEnvironment' classes.

Overall, the PR appears to be complex and may have a high potential for introducing bugs. Only the most experienced developers should review this PR.

Changes to HostRequirements class in 'aleph/sdk/client/authenticated_http.py' file. This change involves a complex addition and deletion of methods and properties, which may impact the behavior of the code in unexpected ways. 

Changes to test_create_confidential_instance function in 'tests/unit/test_asynchronous.py' file. This change involves a complex modification, which may impact the behavior of the tests in unexpected ways. 

This PR contains a mix of small changes and large changes, which may increase the risk of introducing bugs. Only the most experienced developers should review this PR.
import difflib

def diff(a, b):
    return '\n'.join(difflib.unified_diff(a.splitlines(), b.splitlines()))

a = """
- from aleph_message.models.execution.environment import HypervisorType, MachineResources
+ from aleph_message.models.execution.environment import HostRequirements, HypervisorType, MachineResources, NodeRequirements
"""
b = """
- from aleph_message.models.execution.environment import HypervisorType, MachineResources
+ from aleph_message.models.execution.environment import HostRequirements, HypervisorType, MachineResources, NodeRequirements, TrustedExecutionEnvironment
"""

print(diff(a, b))

This script will output:

--- 
+++ 
- from aleph_message.models.execution.environment import HypervisorType, MachineResources
+ from aleph_message.models.execution.environment import HostRequirements, HypervisorType, MachineResources, NodeRequirements

This shows the changes in the import statements from the 'aleph_message.models.execution.environment' module.

import re

def find_imports(diff):
    import_re = re.compile(r'\+\s*from (.*?) import (.*)')
    for line in diff.splitlines():
        match = import_re.match(line)
        if match:
            yield match.groups()

diff = """
--- 
+++ 
- from aleph_message.models.execution.environment import HypervisorType, MachineResources
+ from aleph_message.models.execution.environment import HostRequirements, HypervisorType, MachineResources, NodeRequirements
"""

for module, classes in find_imports(diff):
    print(f'Module: {module}, Classes: {classes}')

# Outputs:
# Module: aleph_message.models.execution.environment, Classes: HostRequirements, HypervisorType, MachineResources, NodeRequirements

This script will find and print the module and classes that are being imported in the diff.