search

aleph-im / aleph-sdk-python

Python SDK library for the Aleph.im network
MIT License
3 stars 5 forks source link

Fix: confest _http_session instead of http_session #150

Closed 1yam closed 2 months ago

github-actions[bot] commented 2 months ago

Summary: The change modifies the attribute name from http_session to _http_session within the AlephHttpClient class. This is a straightforward renaming of an attribute, which does not alter the functionality of the code or introduce any new features. The change is purely cosmetic and does not affect the behavior of the existing codebase.

Highlighting:

-    client.http_session = http_session
+    client._http_session = http_session

Explanation: The modification involves a simple renaming of an attribute from http_session to _http_session. This change does not introduce any new functionality, nor does it affect the behavior of the code. It is a straightforward refactoring aimed at improving the readability or clarity of the codebase. As such, it falls under the 'BLUE' category, which typically includes changes that are unlikely to introduce bugs or require deep understanding of the project architecture.

hoh commented 2 months ago

Can you explain what this fixes ? Why is there a fixup! commit alone in a branch/PR ?

1yam commented 2 months ago

We got this change:

https://github.com/aleph-im/aleph-sdk-python/commit/d2f56b024cd3cff5d725293e786804b61ff791f2

That i didn't see when merging the Price feature. So here the fix