Closed MHHukiewitz closed 1 year ago
Relies on #49
The diff looks good to me. Do we have any test on the new sign_raw
method ?
Relies on #49
Squashed and pushed on master. Can you rebase on it ?
As discussed, sign_raw
should return Bytes. The rest looks good to me.
After suggestion by @hoh I changed the signature of sign_raw(buffer: bytes) -> str:
to sign_raw(buffer: bytes) -> bytes:
.
As this involves a bit more invasive refactoring, I decided that it would only make sense to add more unit tests, especially to the non-existent Cosmos and Substrate (Polkadot) tests.
BaseAccount.sign_raw()
accepts raw bytes and outputs a signature as a string in the preferred encoding.This allows signing of arbitrary data besides Aleph messages, making it a useful tool in dApp development.