aleph-im / aleph-sdk-python

Python SDK library for the Aleph.im network
MIT License
3 stars 4 forks source link

Fix workflow triggers for Forked-Repo-PRs #71

Closed MHHukiewitz closed 10 months ago

MHHukiewitz commented 10 months ago

Problem: build-wheels.yml and pytest-docker.yml would not trigger if a PR was created from a forked repo.

Solution: Trigger all the workflows on direct pushes to main and on any PR to main.

Indication comes from #69 and #47, which were both PRs that did not trigger all workflows and both were attempted merges from 1yam's forked repo.

hoh commented 10 months ago

We should run CI on all branches and Pull Requests.

What about using this ?

on:
  push:
  pull_request:
MHHukiewitz commented 10 months ago
on:
  push:
[...]

Won't this cause the CI to trigger on every push on every branch, even without PR in place?

Thought it would be important to save on unnecessary GH actions usage

hoh commented 10 months ago

Good point.

The main thing that consumes our CI usage is the replication due to the matrix of versions.

We should run: