Closed MHHukiewitz closed 9 months ago
The changes in this PR can be considered as having moderate risks due to the following reasons:
ForgottenMessageError
which extends the base QueryError
.get_message
, get_messages
, and get_posts
that involve changes in how they interact with the API, such as using async context managers and handling different response statuses.The PR also includes some refactoring and documentation updates, but these changes are relatively minor and do not significantly increase the complexity of the review.
In summary, this PR requires a deeper understanding of the project architecture and potential risks involved in handling forgotten messages and different API response statuses. Therefore, it is categorized as 'RED'.
Inspired by https://github.com/aleph-im/aleph-client/pull/129/files:
get_message
now requires less parameters and raisesForgottenMessageError
if message existed, but was forgotten/api/v0/messages/{item_hash}
endpoint to do so -> should potentially lead to performance improvementstest_asynchronous_get.py
are now fully mockedtest_asynchronous_get.py
andtest_asynchronous.py
to be included inconftest.py