aleph-im / aleph-sdk-python

Python SDK library for the Aleph.im network
MIT License
3 stars 4 forks source link

Refactor: Add `InsufficientFundsError` in `create_instance` #86

Closed MHHukiewitz closed 9 months ago

MHHukiewitz commented 9 months ago
github-actions[bot] commented 9 months ago

The changes in this PR include:

  1. Adding a new parameter raise_on_rejected to several methods in aleph-sdk-python. This involves modifying function signatures and updating calls to these functions throughout the codebase.
  2. Introducing a new exception InsufficientFundsError in exceptions.py.
  3. Adding a new fixture rejected_message in conftest.py for use in testing.
  4. Updating several test functions to handle the new raise_on_rejected parameter and the new InsufficientFundsError exception.

These changes introduce complexity at multiple levels of the codebase, including modifications to core functionality, introduction of a new error type, and updates to testing. As such, this PR requires careful review to ensure that these changes do not introduce bugs or unintended side effects.