Closed MHHukiewitz closed 9 months ago
This PR is categorized as 'BLACK' due to the extensive changes it introduces. The changes include:
DEFAULT_VM_MEMORY
, DEFAULT_VM_VCPUS
, and DEFAULT_VM_TIMEOUT
in conf.py
.validate_vcpus
, validate_memory
, validate_timeout
) in utils.py
.authenticated_http.py
that include calls to these validation functions.These changes have a high potential for introducing bugs, as they affect the core functionality of the library by modifying default values and adding new constraints on resource usage. Additionally, the addition of new validation functions requires deep understanding of the project architecture and could introduce new bugs if not implemented correctly.
As discussed in the meeting today, hardcoding such limits in the SDK does not make sense.
DEFAULT_VM_MEMORY
to 2000ValueError
if validation of eithermemory
,vcpus
ortimeout
has invalid values.Suggested value ranges:
memory
<= 8000 MiBvcpus
<= 4timeout
<= 180