Multiple "set-cookie" header are overwritten by the "supervisord" - Githubissues

aleph-im / aleph-vm

Aleph.im VM execution engine

MIT License

42 stars 18 forks source link

Multiple "set-cookie" header are overwritten by the "supervisord" #324

Closed aliel closed 11 months ago

aliel commented 1 year ago

Several "set-cookie" headers are allowed by RFC6265: https://datatracker.ietf.org/doc/html/rfc6265#section-3

vm_supervisord should correctly handle "set-cookie" headers: https://github.com/aleph-im/aleph-vm/blob/40c5c5bdd406a8a5945799f5d287269b6fbda3a1/vm_supervisor/run.py#L137

hoh commented 1 year ago

This should probably use a https://multidict.aio-libs.org/en/stable/multidict.html#multidict.CIMultiDictProxy

aliel commented 11 months ago

merged: https://github.com/aleph-im/aleph-vm/pull/327