search

aleph-im / aleph-vm

Aleph.im VM execution engine
MIT License
43 stars 18 forks source link

Small fixes noticed on new installations. #659

Closed nesitor closed 3 months ago

nesitor commented 4 months ago

Problem: If the server doesn't have access to Internet, it just crashes. Also, if an instance is removed, it fails removing the base block device.

Solution: Handle the crash and log as an error about the Internet connection. Check if the mounted block devices exist before removing it.

nesitor commented 3 months ago

These are two completely unrelated fixes, can you at least make two distinct commits, preferably two PRs ?

This is not totally unrelated, are issues found installing a new server. Why put it in different commits or different PRs? It's just 6 lines of code in total.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.72%. Comparing base (a27a488) to head (c2e4fa1).

Files Patch % Lines
src/aleph/vm/hypervisors/firecracker/microvm.py 50.00% 1 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #659 +/- ## ========================================== - Coverage 61.82% 61.72% -0.11% ========================================== Files 68 68 Lines 5959 5964 +5 Branches 624 627 +3 ========================================== - Hits 3684 3681 -3 - Misses 2124 2128 +4 - Partials 151 155 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.