Closed olethanh closed 2 months ago
Attention: Patch coverage is 16.66667%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 61.31%. Comparing base (
0b4fbfd
) to head (35f6227
). Report is 5 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
src/aleph/vm/hypervisors/firecracker/microvm.py | 16.66% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What would happen if the cache is cleared while a VM is working and using a file stored there then ? With hardlinks, this would not be an issue since the file would still exist.
After @nesitor feedback and more testing I have found a workaround: Do a copy if we can't do a link. Tested and it works properly
What would happen if the cache is cleared while a VM is working and using a file stored there then ? With hardlinks, this would not be an issue since the file would still exist.
While the VM is working the file is open, and as long as a program has a fd to a file Linux won't actually delete it from the disk so it isn't a problem. But anyway we don't use a symlink anymore
…separate partion
The prepare step for jailer was failing because it couldn't create a link to rootfs file when the CACHE and EXECUTION were not on the same partition
This was due do trying to make a hardlink instead of as soft symlink (contrary to what the docstring indicated)
Solution: Make a symlink