aleph-im / front-aleph-cloud-page

1 stars 0 forks source link

Allow unconnected users to browse Dapp #75

Closed leirbag95 closed 5 months ago

leirbag95 commented 11 months ago

Linked to this issue #21

Description: This pull request aims to enhance the user experience by removing the requirement for users to be connected in order to browse the Dapp and create instances. It introduces changes to the application flow to facilitate access for unconnected users while maintaining the necessary functionalities related to instance creation.

Changes:

Improved accessibility for users, allowing them to explore the Dapp and initiate the instance creation process without the barrier of mandatory prior connection. Enhanced user experience by streamlining the onboarding process.

Screenshots:

Capture d’écran 2023-11-03 à 08 59 29 Capture d’écran 2023-11-03 à 09 00 06 Capture d’écran 2023-11-03 à 08 59 56

Code: I removed the redirection from useConnectedWard.ts file

export default function useConnectedWard(route = '/') {
  const [state] = useAppState()
  const router = useRouter()

  useEffect(() => {
    if (!state.account) {
      router.replace(route)
    }
  })
}

And add same button as Header at the end of instance creation process

claudioALEPH commented 10 months ago

You only added the button on the new function page. Each product pages need to have this behavior, since they all require at least a message to be sent.

Recreating the "wallet picker" at the bottom of the page does not make much sense to me. The button below the "Holding Requirements" section should scroll to the top of the page. image

Besides, when trying to connect using that button, an error is issued because the default behavior of a button is to send the parent form it is contained in.

Totally agree!

amalcaraz commented 5 months ago

Closing this PR. This should be refined more in detail.