search

alephcloud / hs-configuration-tools

Tools for defining and parsing configurations of Haskell applications
MIT License
23 stars 4 forks source link

Issue #43: detect repository type from within sub directory #44

Closed larskuhtz closed 9 years ago

larskuhtz commented 9 years ago

This is supposed to solve issue #43.

gregwebs commented 9 years ago

I am personally not a fan of cd .. but I can see how this is a more convenient implementation than trying to execute git or hg which I guess must be doing something like that anyways.

The change looks good to merge, but it seems that there could be some Travis CI issues.

larskuhtz commented 9 years ago

I think using cd .. for this is pretty standard. I tried to do the implementation in a way that does hopefully work on all platforms. Luckily git and hg both have been careful to not name the user-level configuration files/directories .git and .hg but gitconfig and .hgrc, respectively. Otherwise this approach would break.

Yeah, the travis-setup is somewhat hacky. Together with travis-ci recently being somewhat slow this sometimes results in timeouts:

No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.
larskuhtz commented 9 years ago

The travis-ci failures all seem unrelated, so I merge this. I opened a separate issue #45 for resolving the travis-ci issues.