Replace non-ascii identifiers in types

alephcloud / hs-configuration-tools

Tools for defining and parsing configurations of Haskell applications

MIT License

23 stars 4 forks source link

Replace non-ascii identifiers in types #60

Closed axman6 closed 7 years ago

axman6 commented 7 years ago

Arrows and ::'s have not been replaced as their meaning is clear (though makes grepping harder)
Where possible the canonical names found elsewhere in the Haskell ecosystem have been used (m for Monad, f for Functor or Applicative, p for profunctor etc.)

I believe I've caught all uses of non-ascii identifiers, but it's possible I missed some as the search was manual. See discussion in #58

larskuhtz commented 7 years ago

Could you please revert forall back to ∀? It's a keyword and not an identifier. Also, it's standard mathematical notation. I think it keeps type signatures more compact and readable.

Otherwise, the PR looks good.

axman6 commented 7 years ago

Done

larskuhtz commented 7 years ago

Thanks for contributing to the package!