search

alephdata / aleph

Search and browse documents and data; find the people and companies you look for.
http://docs.aleph.occrp.org
MIT License
2.04k stars 272 forks source link

FEATURE: Display confirmation dialog when clicking on links from source documents #3225

Open tillprochaska opened 1 year ago

tillprochaska commented 1 year ago

Is your feature request related to a problem? Please describe. We currently render links in email and HTML previews. Clicking on links from source documents can be potentially unsafe or notify authors.

Describe the solution you'd like We should display a confirmation popup informing users about the risks of opening links from source documents.

Describe alternatives you've considered Alternatively, we could not render a clickable link and instead display the target URL in parenthesis after the link label so users have to actively copy and paste the URL.

Additional context -/-

SURAJ-SHARMA27 commented 3 months ago

Hi @tillprochaska, I would like to work on the above issue, but I want to confirm before proceeding: Is the issue that upon clicking the email link, it directly redirects to the link? Should I trigger a confirmation dialog before redirecting to that page?

screen-capture (10).webm

tillprochaska commented 3 months ago

Hi @SURAJ-SHARMA27, and thanks for reaching out before starting to work on an issue. Sorry for my slow reply!

Is the issue that upon clicking the email link, it directly redirects to the link?

Yes, this is the issue. While in your scree capture this applies to mailto links, this applies to any other link linking to a normal web page as well.

Ideally, there should be a confirmation dialog similar to the dialog that opens after clicking on the "Download" button. The confirmation dialog should show the URL the user will be redirected to. Only after clicking on a button in the confirmation dialog, the URL should be opened in a new tab.

Let me know in case you need help or have further questions!