search

alephdata / followthemoney

Data model and processing tools for investigative entity data
https://followthemoney.tech
MIT License
217 stars 53 forks source link

Bump identifier length to handle XMR addresses #1518

Closed jbothma closed 2 months ago

jbothma commented 2 months ago

We'd like to be able to represent the XMR addresses at https://www.treasury.gov/ofac/downloads/sanctions/1.0/sdn_advanced.xml as CryptoWallet:publicKey

They are 96 chars long.

pudo commented 2 months ago

There's a tiny bit of me wondering if we want to have property.max_length which defaults to prop.type.max_length but can be overridden with more specific details....

jbothma commented 2 months ago

That sounds quite nice - this would make ftm schemas a bit more like sql schemas. It probably helps reduce size edits in the types and gives granular control to keep tighter limits which have helped identify dirty data. Would you like me to implement it?

pudo commented 2 months ago

I think so, if you have a minute. Good examples are probably SWIFT BIC, LEI, OGRN etc!

pudo commented 2 months ago

Here's a PR for the more general case: https://github.com/alephdata/followthemoney/pull/1519

jbothma commented 2 months ago

That's way nicer, thanks!