search

alephdata / memorious

Lightweight web scraping toolkit for documents and structured data.
https://docs.alephdata.org/developers/memorious
MIT License
311 stars 59 forks source link

refactor: Add example config path for Docker #126

Closed lassebenni closed 4 years ago

lassebenni commented 4 years ago

In response to Issue 124 in the example project, it took me (and probably others) some time to figure out that the MEMORIOUS_CONFIG_PATH is not set by default and will result in memorious list not returning any crawlers (or even hinting that the config might be non-existant/erroneous).

I propose a simple adding of the default path /crawlers/config to the Dockerfile in the example, which solves the issue.

An alternative might be adding a warning to the README.md stating that the MEMORIOUS_CONFIG_PATH is not set and has to be set by the user before the Docker container will work correctly.

If I missed something, please let me know =)

sunu commented 4 years ago

Thanks! I'll add a warning about missing config path as well.